Make https binding mandatory for network-based did resolvers #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ottomorac
requested review from
dmitrizagidulin,
mccown,
msporny and
wip-abramson
as code owners
Contributor
|
How is this related to #192, can that PR also be closed? |
Comment on lines
-1596
to
-1598
| <<<<<<< HEAD | ||
| structure such as a map or list MUST be one of these data types as well. | ||
| ======= |
Contributor
There was a problem hiding this comment.
Ooops, not sure how this got in. But quite possibly my fault
wip-abramson
approved these changes
Jan 22, 2026
dmitrizagidulin
approved these changes
Jan 22, 2026
msporny
reviewed
Jan 22, 2026
Comment on lines
+2303
to
+2306
| All <a href="#dfn-conforming-network-based-did-resolver">conforming DID resolvers</a> MUST implement the GET version of the | ||
| <a href="#bindings-https">HTTPS binding</a> and MAY implement the POST version. | ||
| All <a href="#bindings-https">HTTPS bindings</a> MUST use TLS. Use of DNS names | ||
| in certificates is NOT REQUIRED; resolvers MAY use TLS certificates issued for IP addresses. |
Member
There was a problem hiding this comment.
Suggested change
| All <a href="#dfn-conforming-network-based-did-resolver">conforming DID resolvers</a> MUST implement the GET version of the | |
| <a href="#bindings-https">HTTPS binding</a> and MAY implement the POST version. | |
| All <a href="#bindings-https">HTTPS bindings</a> MUST use TLS. Use of DNS names | |
| in certificates is NOT REQUIRED; resolvers MAY use TLS certificates issued for IP addresses. | |
| All <a href="#dfn-conforming-network-based-did-resolver">conforming network-based DID resolvers</a> MUST implement the GET version of the | |
| <a href="#bindings-https">HTTPS binding</a> and MAY implement the POST version. |
TallTed
reviewed
Jan 22, 2026
| <<<<<<< HEAD | ||
| structure such as a map or list MUST be one of these data types as well. | ||
| ======= | ||
| structure such as a map or list MUST also be one of these data types. |
Member
There was a problem hiding this comment.
This concern is also seen in a very similar issue/PR. MUST also be one of these data types says to me that the values within any complex data structure such as a map or list MUST also be a complex data structure such as a map or list or similar, rather than permitting the simple data structures previously listed. I suggest just repeating the list, for clarity, even though it lengthens the paragraph.
This was referenced Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #93
I had to abandon the previous PR #182 because it was too out of synch with the main branch.
Preview | Diff